Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakdown tab for payments and offercreates #985

Open
wants to merge 82 commits into
base: staging
Choose a base branch
from

Conversation

shortthefomo
Copy link
Contributor

@shortthefomo shortthefomo commented May 22, 2024

This PR adds a breakdown section to payments and offercreates

Context of Change

This adds the ability to show where the liquidity for the transaction was sourced. Via AMM/DEX/DIRECT and if RIPPLING was involved.

Screenshot 2024-05-22 at 12 36 05 PM

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

package.json Show resolved Hide resolved
Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

// amountToBalance,
// } from 'xrpl-tx-path-parser'

export const BreakDownTab: FC<{ data: any }> = ({ data }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any objection to adding this breakdown to the existing "Detailed" tab?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@pdp2121
Copy link
Collaborator

pdp2121 commented May 22, 2024

Looks awesome! Probably the dropdown would need a bit redesign, which could be great for reusability as well:
Screenshot 2024-05-22 at 6 45 50 PM

@shortthefomo
Copy link
Contributor Author

shortthefomo commented May 24, 2024

Please add tests.

now in place, I think its ready for another round of review now.

shortthefomo and others added 15 commits May 24, 2024 16:47
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

The link to populate amendment names by id has been changed to:

https://raw.githubusercontent.com/XRPLF/rippled/develop/src/libxrpl/protocol/Feature.cpp

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release
Bumps
[react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom)
from 6.18.0 to 6.24.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/remix-run/react-router/releases">react-router-dom's
releases</a>.</em></p>
<blockquote>
<h2>[email protected]</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies
<ul>
<li>[email protected]</li>
<li>[email protected]</li>
</ul>
</li>
</ul>
<h2>[email protected]</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies
<ul>
<li>[email protected]</li>
<li>[email protected]</li>
</ul>
</li>
</ul>
<h2>[email protected]</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies
<ul>
<li>[email protected]</li>
<li>[email protected]</li>
</ul>
</li>
</ul>
<h2>[email protected]</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies
<ul>
<li>[email protected]</li>
<li>[email protected]</li>
</ul>
</li>
</ul>
<h2>[email protected]</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies
<ul>
<li>[email protected]</li>
<li>[email protected]</li>
</ul>
</li>
</ul>
<h2>[email protected]</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies
<ul>
<li><code>[email protected]</code></li>
<li><code>[email protected]</code></li>
</ul>
</li>
</ul>
<h2>[email protected]</h2>
<h3>Patch Changes</h3>
<ul>
<li>44bce3c6: Fix <code>react-router-dom</code> peer dependency version
<ul>
<li>[email protected]</li>
<li>[email protected]</li>
</ul>
</li>
</ul>
<h2>[email protected]</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md">react-router-dom's
changelog</a>.</em></p>
<blockquote>
<h2>6.24.0</h2>
<h3>Minor Changes</h3>
<ul>
<li>
<p>Add support for Lazy Route Discovery (a.k.a. Fog of War) (<a
href="https://redirect.github.com/remix-run/react-router/pull/11626">#11626</a>)</p>
<ul>
<li>RFC: <a
href="https://github.com/remix-run/react-router/discussions/11113">https://github.com/remix-run/react-router/discussions/11113</a></li>
<li><code>unstable_patchRoutesOnMiss</code> docs: <a
href="https://reactrouter.com/en/main/routers/create-browser-router">https://reactrouter.com/en/main/routers/create-browser-router</a></li>
</ul>
</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li>Fix <code>fetcher.submit</code> types - remove incorrect
<code>navigate</code>/<code>fetcherKey</code>/<code>unstable_viewTransition</code>
options because they are only relevant for <code>useSubmit</code> (<a
href="https://redirect.github.com/remix-run/react-router/pull/11631">#11631</a>)</li>
<li>Allow falsy <code>location.state</code> values passed to
<code>&lt;StaticRouter&gt;</code> (<a
href="https://redirect.github.com/remix-run/react-router/pull/11495">#11495</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>[email protected]</code></li>
<li><code>@remix-run/[email protected]</code></li>
</ul>
</li>
</ul>
<h2>6.23.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Check for <code>document</code> existence when checking
<code>startViewTransition</code> (<a
href="https://redirect.github.com/remix-run/react-router/pull/11544">#11544</a>)</li>
<li>Change the <code>react-router-dom/server</code> import back to
<code>react-router-dom</code> instead of <code>index.ts</code> (<a
href="https://redirect.github.com/remix-run/react-router/pull/11514">#11514</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/[email protected]</code></li>
<li><code>[email protected]</code></li>
</ul>
</li>
</ul>
<h2>6.23.0</h2>
<h3>Minor Changes</h3>
<ul>
<li>Add a new <code>unstable_dataStrategy</code> configuration option
(<a
href="https://redirect.github.com/remix-run/react-router/pull/11098">#11098</a>)
<ul>
<li>This option allows Data Router applications to take control over the
approach for executing route loaders and actions</li>
<li>The default implementation is today's behavior, to fetch all loaders
in parallel, but this option allows users to implement more advanced
data flows including Remix single-fetch, middleware/context APIs,
automatic loader caching, and more</li>
</ul>
</li>
</ul>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/[email protected]</code></li>
<li><code>[email protected]</code></li>
</ul>
</li>
</ul>
<h2>6.22.3</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/[email protected]</code></li>
<li><code>[email protected]</code></li>
</ul>
</li>
</ul>
<h2>6.22.2</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/remix-run/react-router/commit/a569d7699fbd6760fd2d5a339aab9bc0caf750ab"><code>a569d76</code></a>
chore: Update version for release (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11717">#11717</a>)</li>
<li><a
href="https://github.com/remix-run/react-router/commit/a2f718bb037d9ec82d82339bade7e82af0bc8b1a"><code>a2f718b</code></a>
chore: Update version for release (pre) (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11661">#11661</a>)</li>
<li><a
href="https://github.com/remix-run/react-router/commit/4e85e9884c2c0c7125edc91941b3e023a9d3180c"><code>4e85e98</code></a>
Support lazy route discovery (fog of war) (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11626">#11626</a>)</li>
<li><a
href="https://github.com/remix-run/react-router/commit/be8a2590eb3ebd91294835031ff788d4fd59070c"><code>be8a259</code></a>
Fix fetcher.submit types (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11631">#11631</a>)</li>
<li><a
href="https://github.com/remix-run/react-router/commit/58dcfbb97db73a6d29f12a9ab8567540b8e9a24b"><code>58dcfbb</code></a>
Merge branch 'release-next' into dev</li>
<li><a
href="https://github.com/remix-run/react-router/commit/aef5c4a617756e6fcc493de17b4be9997a5a19c8"><code>aef5c4a</code></a>
chore: Update version for release (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11551">#11551</a>)</li>
<li><a
href="https://github.com/remix-run/react-router/commit/26bc8e295398b571104ef529149c22a0724eeb7e"><code>26bc8e2</code></a>
chore: Update version for release (pre) (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11545">#11545</a>)</li>
<li><a
href="https://github.com/remix-run/react-router/commit/031478d4acc46cc631673ef14e3215fac97dee8b"><code>031478d</code></a>
Add defensive window.document check when checking for
startViewTransition (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/1">#1</a>...</li>
<li><a
href="https://github.com/remix-run/react-router/commit/127e69343f8eeb2233a8bec37d97fca5541f90a1"><code>127e693</code></a>
Fix useLocation to receive 0 instead of null when state is set to 0 (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11495">#11495</a>)</li>
<li><a
href="https://github.com/remix-run/react-router/commit/9651465485fc6c96c1dd793a96d8af8f1ebf42d0"><code>9651465</code></a>
chore: Update version for release (pre) (<a
href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/11516">#11516</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/remix-run/react-router/commits/[email protected]/packages/react-router-dom">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-router-dom&package-manager=npm_and_yarn&previous-version=6.18.0&new-version=6.24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
## High Level Overview of Change

This PR removes `XChain` from the homepage legend.

### Context of Change

XLS-38 has been put on hiatus for now. If it starts moving back towards
being activated, we can revert this commit.

### Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)
dependabot bot and others added 30 commits November 1, 2024 16:19
## High Level Overview of Change

In order to improve the usability of the search bar inside of Explorer,
matching tokens will now auto-populate as a user is typing. The results
are clickable and redirect to the respective token page. The data is
pulled from XRPLMeta and cached inside of the Explorer backend to
display an open sourced list of tokens and relevant statistics.

Backend changes implement serverside caching of tokens data from XRPL
Meta, and exposes an API from the explorer backend for search result
querying. This is less expensive than the previous approach of
websockets (which remain open for the duration of a user session) and
are susceptible to rate limits on XRPLMeta's public node infrastructure.
This also offers resilience in the case that the public XRPLMeta node
has downtime.

Desktop:
<img width="906" alt="Screenshot 2024-11-05 at 4 36 33 PM"
src="https://github.com/user-attachments/assets/8f19503d-74fc-474f-b946-534c028ce4a9">

Mobile:
<img width="453" alt="Screenshot 2024-11-05 at 4 37 26 PM"
src="https://github.com/user-attachments/assets/3ba5ba0d-1fe0-4bfd-97fe-a32f12420490">


<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->

---------

Co-authored-by: Phu Pham <[email protected]>
Co-authored-by: pdp2121 <[email protected]>
Co-authored-by: Caleb Kniffen <[email protected]>
## High Level Overview of Change

We want important tokens like RLUSD to not be filtered out. Since this
token is new, it doesn't meet the minimum requirements of the filters we
put in place previously. To remain partial, we now exclude all
trust_level 3 tokens from the filters, which fixes this issue for RLUSD
as well.

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
## High Level Overview of Change

Add URL to template based on recent token search release

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
Bumps [sass](https://github.com/sass/dart-sass) from 1.76.0 to 1.80.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/sass/dart-sass/releases">sass's
releases</a>.</em></p>
<blockquote>
<h2>Dart Sass 1.80.5</h2>
<p>To install Sass 1.80.5, download one of the packages below and <a
href="https://katiek2.github.io/path-doc/">add it to your PATH</a>, or
see <a href="https://sass-lang.com/install">the Sass website</a> for
full installation instructions.</p>
<h1>Changes</h1>
<h3>Embedded Host</h3>
<ul>
<li>Don't produce phantom <code>@import</code> deprecations when using
an importer with the legacy API.</li>
</ul>
<p>See the <a
href="https://github.com/sass/dart-sass/blob/master/CHANGELOG.md#1805">full
changelog</a> for changes in earlier releases.</p>
<h2>Dart Sass 1.80.4</h2>
<p>To install Sass 1.80.4, download one of the packages below and <a
href="https://katiek2.github.io/path-doc/">add it to your PATH</a>, or
see <a href="https://sass-lang.com/install">the Sass website</a> for
full installation instructions.</p>
<h1>Changes</h1>
<ul>
<li>No user-visible changes.</li>
</ul>
<p>See the <a
href="https://github.com/sass/dart-sass/blob/master/CHANGELOG.md#1804">full
changelog</a> for changes in earlier releases.</p>
<h2>Dart Sass 1.80.3</h2>
<p>To install Sass 1.80.3, download one of the packages below and <a
href="https://katiek2.github.io/path-doc/">add it to your PATH</a>, or
see <a href="https://sass-lang.com/install">the Sass website</a> for
full installation instructions.</p>
<h1>Changes</h1>
<ul>
<li>
<p>Fix a bug where <code>@import url(&quot;...&quot;)</code> would crash
in plain CSS files.</p>
</li>
<li>
<p>Improve consistency of how warnings are emitted by different parts of
the compiler. This should result in minimal user-visible changes, but
different types of warnings should now respond more reliably to flags
like <code>--quiet</code>, <code>--verbose</code>, and
<code>--silence-deprecation</code>.</p>
</li>
</ul>
<p>See the <a
href="https://github.com/sass/dart-sass/blob/master/CHANGELOG.md#1803">full
changelog</a> for changes in earlier releases.</p>
<h2>Dart Sass 1.80.2</h2>
<p>To install Sass 1.80.2, download one of the packages below and <a
href="https://katiek2.github.io/path-doc/">add it to your PATH</a>, or
see <a href="https://sass-lang.com/install">the Sass website</a> for
full installation instructions.</p>
<h1>Changes</h1>
<ul>
<li>Fix a bug where deprecation warnings were incorrectly emitted for
the plain-CSS <code>invert()</code> function.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/sass/dart-sass/blob/main/CHANGELOG.md">sass's
changelog</a>.</em></p>
<blockquote>
<h2>1.80.5</h2>
<h3>Embedded Host</h3>
<ul>
<li>Don't produce phantom <code>@import</code> deprecations when using
an importer with the
legacy API.</li>
</ul>
<h2>1.80.4</h2>
<ul>
<li>No user-visible changes.</li>
</ul>
<h2>1.80.3</h2>
<ul>
<li>
<p>Fix a bug where <code>@import url(&quot;...&quot;)</code> would crash
in plain CSS files.</p>
</li>
<li>
<p>Improve consistency of how warnings are emitted by different parts of
the
compiler. This should result in minimal user-visible changes, but
different
types of warnings should now respond more reliably to flags like
<code>--quiet</code>,
<code>--verbose</code>, and <code>--silence-deprecation</code>.</p>
</li>
</ul>
<h2>1.80.2</h2>
<ul>
<li>Fix a bug where deprecation warnings were incorrectly emitted for
the
plain-CSS <code>invert()</code> function.</li>
</ul>
<h2>1.80.1</h2>
<ul>
<li>Fix a bug where repeated deprecation warnings were not automatically
limited.</li>
</ul>
<h2>1.80.0</h2>
<ul>
<li><code>@import</code> is now officially deprecated, as are global
built-in functions that
are available within built-in modules. See <a
href="https://sass-lang.com/blog/import-is-deprecated/">the Sass blog
post</a> for more
details on the deprecation process.</li>
</ul>
<h3>Embedded Host</h3>
<ul>
<li>Fix an error that would sometimes occur when deprecation warnings
were
emitted when using a custom importer with the legacy API.</li>
</ul>
<h2>1.79.6</h2>
<ul>
<li>
<p>Fix a bug where Sass would add an extra <code>*/</code> after loud
comments with
whitespace after an explicit <code>*/</code> in the indented syntax.</p>
</li>
<li>
<p><strong>Potentially breaking bug fix:</strong> Adding text after an
explicit <code>*/</code> in the
indented syntax is now an error, rather than silently generating invalid
CSS.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/sass/dart-sass/commit/d14ea754e96861c9d7cb7f2b4bc75a40364eaf31"><code>d14ea75</code></a>
Cut a release for <a
href="https://redirect.github.com/sass/embedded-host-node/issues/342">sass/embedded-host-node#342</a>
(<a
href="https://redirect.github.com/sass/dart-sass/issues/2407">#2407</a>)</li>
<li><a
href="https://github.com/sass/dart-sass/commit/7129352416784039902fbea8848c5b54f957e05b"><code>7129352</code></a>
Fix dart analyze warnings (<a
href="https://redirect.github.com/sass/dart-sass/issues/2412">#2412</a>)</li>
<li><a
href="https://github.com/sass/dart-sass/commit/5c63839328b19782bc9a434a77f6028561906b96"><code>5c63839</code></a>
Bump the sass_api dependency along with package versions (<a
href="https://redirect.github.com/sass/dart-sass/issues/2408">#2408</a>)</li>
<li><a
href="https://github.com/sass/dart-sass/commit/477b596e0527f004205dbbdf6b6433c2907799ce"><code>477b596</code></a>
Merge pull request <a
href="https://redirect.github.com/sass/dart-sass/issues/2403">#2403</a>
from sass/parser-variable</li>
<li><a
href="https://github.com/sass/dart-sass/commit/fd5cff0e7908d73d48de6a8484dde888079cbb44"><code>fd5cff0</code></a>
Add sass-parser support for the <code>@warn</code> rule</li>
<li><a
href="https://github.com/sass/dart-sass/commit/251c75714331728b1336d72710c490068de2bfef"><code>251c757</code></a>
Add sass-parser support for variable declarations</li>
<li><a
href="https://github.com/sass/dart-sass/commit/20397efa740929f95f3e18db996af84b81a0fd6f"><code>20397ef</code></a>
Add grinder tasks to bump package versions (<a
href="https://redirect.github.com/sass/dart-sass/issues/2405">#2405</a>)</li>
<li><a
href="https://github.com/sass/dart-sass/commit/c907bcb57281b51efbd7b0957ac8a4d0bead8818"><code>c907bcb</code></a>
Expose Expression.isCalculationSafe to sass_api (<a
href="https://redirect.github.com/sass/dart-sass/issues/2404">#2404</a>)</li>
<li><a
href="https://github.com/sass/dart-sass/commit/37a05f97f3ee3cec8156e5a87076c0526477bdff"><code>37a05f9</code></a>
Enable AOT build for android-riscv64 (<a
href="https://redirect.github.com/sass/dart-sass/issues/2399">#2399</a>)</li>
<li><a
href="https://github.com/sass/dart-sass/commit/473ddf9100cce7b96d3ef01b8e060f8d4517a37e"><code>473ddf9</code></a>
Add <code>sass-parser</code> support for the <code>@use</code> rule (<a
href="https://redirect.github.com/sass/dart-sass/issues/2389">#2389</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/sass/dart-sass/compare/1.76.0...1.80.5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sass&package-manager=npm_and_yarn&previous-version=1.76.0&new-version=1.80.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Reynolds <[email protected]>
Co-authored-by: Ashray Chowdhry <[email protected]>
## High Level Overview of Change

Add translations to the EnableAmendment/Simple.tsx file for the table
labels. Small code cleanup raised in
ripple#1076

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
## High Level Overview of Change

Title says it all.

### Context of Change

Deprecation notices on Actions:
> The following actions use a deprecated Node.js version and will be
forced to run on node20: actions/checkout@v3, actions/setup-node@v3,
actions/cache@v3. For more info:
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

### Type of Change

- [x] Tests (You added tests for code that already exists, or your new
feature included in this PR)

### TypeScript/Hooks Update

N/A

## Test Plan

The notices go away now.
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
## High Level Overview of Change

Title says it all. There are multiple connections made to a node in the
current implementation, at different ports (which all forward to the
same place on livenet). While the connection isn't sustained, it still
has to be made and canceled.

### Context of Change

There is a lot of load on s2 right now, so saving a connection or two
might make a difference.

### Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)

### TypeScript/Hooks Update

N/A

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

Tested locally.
…ripple#1097)

## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change
Before
<img width="1170" alt="image"
src="https://github.com/user-attachments/assets/3101cfdd-ef88-4ab0-8591-d6e18e8e9abd"
/>

after
<img width="1189" alt="image"
src="https://github.com/user-attachments/assets/faf4a733-8661-4841-a81f-5f2e52f544bc"
/>
`getMPTIssuance` fails to fetch the MPT because the MPT itself has been
deleted. Clio's ledger_entry API supports querying deleted object by
specifying `include_deleted` to be true
<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
## High Level Overview of Change
rippled change that renames MPTokenHolder:
XRPLF/rippled@b636836
<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
## High Level Overview of Change

Bug in the conditional rendering logic for issuer address, it
accidentally double printed the issuer if a name was not provided in the
data. Now only prints the issuer once with no parenthesis if a name is
not provided.

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
The token page is prone to being throttled because it tries to load in
order books for the "top 10 tokens". This change moves logic to useQuery
and out of redux. It then makes sure the token's information is loaded
in before trying to load in dex pairs.

Fixes ripple#790

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] Refactor (non-breaking change that only restructures code)
- [x] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

- [ ] Updated files to React Hooks
- [x] Updated files to TypeScript

## Before / After

### Before
![Monosnap XRPL Explorer | Something bad happened 2024-12-17
14-04-17](https://github.com/user-attachments/assets/27ea108e-59ec-4318-9da3-60ec68c3c38c)

### After
![Monosnap XRPL Explorer | rMxCKbEDwqr7 2024-12-17
14-04-24](https://github.com/user-attachments/assets/7cc2d0d3-d686-408d-a5d2-d3c1c2f8880f)
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

Fix these warnings in build:

```
Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api

transforming (891) ../node_modules/topojson-client/src/identity.jsDeprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

  ╷
1 │ @import '../../css/variables';
  │         ^^^^^^^^^^^^^^^^^^^^^
  ╵
    src/containers/shared/components/TokenSearchResults/styles.scss 1:9  root stylesheet
Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
164 │     font-weight: 500;
    │     ^^^^^^^^^^^^^^^^ declaration
... │
200 │ ┌     @media (min-width: $desktop-upper-boundary) {
201 │ │       @content;
202 │ │     }
    │ └─── nested rule
    ╵
    src/containers/shared/css/variables.scss 164:3  medium()
    src/containers/NFT/NFTTabs/styles.scss 67:7     root stylesheet
```

Resolve ripple#1121

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release
fix spelling

Co-authored-by: Mayukha Vadari <[email protected]>
use of ternary

Co-authored-by: Mayukha Vadari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants